> On Aug. 26, 2015, 9:57 a.m., Joris Van Remoortere wrote:
> > include/mesos/maintenance/maintenance.proto, line 33
> > <https://reviews.apache.org/r/36571/diff/14/?file=1048531#file1048531line33>
> >
> >     Why the choice of repeated `MachineInfo` over `MachineInfos`?

Mostly because of how this is created/accessed.  If I used `MachineInfos`, we'd 
end up with `.machine_infos().machine_infos()`, instead of just 
`.machine_infos()`.  And I don't think there will be any extension of 
MachineInfos with extra fields.


> On Aug. 26, 2015, 9:57 a.m., Joris Van Remoortere wrote:
> > include/mesos/maintenance/maintenance.proto, line 29
> > <https://reviews.apache.org/r/36571/diff/14/?file=1048531#file1048531line29>
> >
> >     is `interval` referring to the old proto here?
> >     Should we say `A set of machines scheduled to go into maintenance 
> > during the same unavailability.`

Yes and no.  In my head, unavailability, interval, period, range of time, etc 
are all sort of synonyms.

I'll reword anyway to be more clear.


> On Aug. 26, 2015, 9:57 a.m., Joris Van Remoortere wrote:
> > src/Makefile.am, line 428
> > <https://reviews.apache.org/r/36571/diff/14/?file=1048533#file1048533line428>
> >
> >     Is this just a whitespace change?
> >     Want to make sure I'm not missing anything here.

Yes.  Apparently, that line used spaces instead of tabs, contrary to everything 
else in the file.


> On Aug. 26, 2015, 9:57 a.m., Joris Van Remoortere wrote:
> > src/master/registry.proto, line 25
> > <https://reviews.apache.org/r/36571/diff/14/?file=1048534#file1048534line25>
> >
> >     s/master/top level/ to avoid any confusion? Or did you really mean 
> > `master` as in the entity?

Top level sounds better.  I think `master` was used initially because the 
registry persists on nodes related to the master...


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96530
-----------------------------------------------------------


On Aug. 24, 2015, 11:33 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 11:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
>     https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, 
> Draining, Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to