> On Aug. 26, 2015, 9:57 a.m., Joris Van Remoortere wrote: > > A higher level wording question: Do we want to be consistent with `Mode` vs > > `Status`, or did you explicitly use different words? For example, we could > > change `MaintenanceStatus` to `MaintenanceModes`. I'm not necessarily > > saying we should, just asking if this was done for a specific reason.
I named it `status` because we might be storing more than just the mode in the future. (Not for the MVP, but there were considerations of including data like the accept/decline reason from frameworks and such.) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96530 ----------------------------------------------------------- On Aug. 24, 2015, 11:33 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36571/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 11:33 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3066 > https://issues.apache.org/jira/browse/MESOS-3066 > > > Repository: mesos > > > Description > ------- > > * MachineInfo - Describes a single box that holds one or more agents. > * MachineInfos - A list of boxes. > * maintenance::Window - A set of machines and a planned downtime period. > * maintenance::Schedule - A set of maintenance windows. > * maintenance::Mode - An enum for the three states of maintenance: Normal, > Draining, Deactivated. > * Registry::MaintenanceStatus - Holds the maintenance mode of a machine. > > > Diffs > ----- > > include/mesos/maintenance/maintenance.hpp PRE-CREATION > include/mesos/maintenance/maintenance.proto PRE-CREATION > include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 > src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db > src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 > > Diff: https://reviews.apache.org/r/36571/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
