This is an automatically generated e-mail. To reply, visit:

A higher level wording question: Do we want to be consistent with `Mode` vs 
`Status`, or did you explicitly use different words? For example, we could 
change `MaintenanceStatus` to `MaintenanceModes`. I'm not necessarily saying we 
should, just asking if this was done for a specific reason.

include/mesos/maintenance/maintenance.proto (line 29)

    is `interval` referring to the old proto here?
    Should we say `A set of machines scheduled to go into maintenance during 
the same unavailability.`

include/mesos/maintenance/maintenance.proto (line 33)

    Why the choice of repeated `MachineInfo` over `MachineInfos`?

include/mesos/maintenance/maintenance.proto (line 42)

    Looks like you're trying to stick to `agent` in this file. s/slaves/agents
    Can we find a better word for `blackout`? Maybe something like `upgrade`?

include/mesos/maintenance/maintenance.proto (line 58)

    Can we reword this a little? I understand what you are trying to say, but 
it might not be clear to a newcomer.
    The `agent` is not releasing the resources, rather the agent is in 
co-operation with the frameworks to try and drain / evacuate / release 
resources in such a way that we still maximize utilization but without 
knowingly violating SLAs.
    The ideal scenario would be that the agent is fully utilized right up until 
the maintenance window, but no critical tasks end up getting killed, right?

include/mesos/mesos.proto (line 111)

    Can you expand on this comment and explain how the IP vs. hostname matching 
will work? I know you're explaining this elsewhere, but here in the proto is a 
common place for users to come look to understand how this message works, and 
what the expectations are.

src/Makefile.am (line 428)

    Is this just a whitespace change?
    Want to make sure I'm not missing anything here.

src/master/registry.proto (line 25)

    s/master/top level/ to avoid any confusion? Or did you really mean `master` 
as in the entity?

src/master/registry.proto (line 42)

    Can we use backticks (`)

src/master/registry.proto (line 58)

    backticks (`)?

- Joris Van Remoortere

On Aug. 24, 2015, 6:33 p.m., Joseph Wu wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> -----------------------------------------------------------
> (Updated Aug. 24, 2015, 6:33 p.m.)
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> Bugs: MESOS-3066
>     https://issues.apache.org/jira/browse/MESOS-3066
> Repository: mesos
> Description
> -------
> * MachineInfo - Describes a single box that holds one or more agents.
> * MachineInfos - A list of boxes.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> * maintenance::Mode - An enum for the three states of maintenance: Normal, 
> Draining, Deactivated.
> * Registry::MaintenanceStatus - Holds the maintenance mode of a machine.
> Diffs
> -----
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
>   src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> Diff: https://reviews.apache.org/r/36571/diff/
> Testing
> -------
> `make check`
> Thanks,
> Joseph Wu

Reply via email to