----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96421 -----------------------------------------------------------
src/Makefile.am (line 477) <https://reviews.apache.org/r/37427/#comment151767> Group token_manager.hpp with other provisioner header files, see lines 740-744. src/slave/containerizer/provisioners/docker/token_manager.hpp (lines 22 - 23) <https://reviews.apache.org/r/37427/#comment151768> Make sure included libraries are in alphabetical order. src/slave/containerizer/provisioners/docker/token_manager.hpp (line 26) <https://reviews.apache.org/r/37427/#comment151769> Same here (libraries in alphabetical order). src/slave/containerizer/provisioners/docker/token_manager.hpp (lines 30 - 33) <https://reviews.apache.org/r/37427/#comment151770> Stout libraries are usually included before process libraries src/slave/containerizer/provisioners/docker/token_manager.hpp (line 57) <https://reviews.apache.org/r/37427/#comment151771> Name parameters. src/slave/containerizer/provisioners/docker/token_manager.hpp (line 96) <https://reviews.apache.org/r/37427/#comment151773> Period at the end of comment. src/slave/containerizer/provisioners/docker/token_manager.hpp (line 97) <https://reviews.apache.org/r/37427/#comment151772> classes are separated by two empty lines. src/slave/containerizer/provisioners/docker/token_manager.hpp (line 198) <https://reviews.apache.org/r/37427/#comment151774> name parameter. src/slave/containerizer/provisioners/docker/token_manager.hpp (line 213) <https://reviews.apache.org/r/37427/#comment151797> place member variables after function declarations. src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 57 - 70) <https://reviews.apache.org/r/37427/#comment151776> Why not just use a private member function? src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 217 - 219) <https://reviews.apache.org/r/37427/#comment151779> Should only be indented 4 spaces. src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 249 - 251) <https://reviews.apache.org/r/37427/#comment151792> Indent 2 more spaces src/slave/containerizer/provisioners/docker/token_manager.cpp (lines 254 - 255) <https://reviews.apache.org/r/37427/#comment151793> Indent by 2 spaces src/slave/containerizer/provisioners/docker/token_manager.cpp (line 318) <https://reviews.apache.org/r/37427/#comment151786> Capitalize beginning of failure messages. src/slave/containerizer/provisioners/docker/token_manager.cpp (line 321) <https://reviews.apache.org/r/37427/#comment151790> indent 2 more spaces? src/slave/containerizer/provisioners/docker/token_manager.cpp (line 323) <https://reviews.apache.org/r/37427/#comment151787> Here too. src/slave/containerizer/provisioners/docker/token_manager.cpp (line 330) <https://reviews.apache.org/r/37427/#comment151789> here too. src/slave/containerizer/provisioners/docker/token_manager.cpp (line 341) <https://reviews.apache.org/r/37427/#comment151791> Fix implementatio typo and period at the end of comment. src/tests/provisioners/docker_provisioner_tests.cpp (line 562) <https://reviews.apache.org/r/37427/#comment151799> extra space here. - Lily Chen On Aug. 24, 2015, 5:16 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37427/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 5:16 p.m.) > > > Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Changes: > - Added Token implementation (RFC 7519). > - Added TokenManager implementation. This component keeps a cache of tokens > requested for any future requests. > > > Diffs > ----- > > src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db > src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION > src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37427/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
