> On Aug. 25, 2015, 10:11 p.m., Lily Chen wrote: > > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 318 > > <https://reviews.apache.org/r/37427/diff/11/?file=1048418#file1048418line318> > > > > Capitalize beginning of failure messages.
for internal error messages (that bubbles up), the leaf level messsages are recommended to start with lower case. This is so that when the root level logger logs the message, it does not look like : "Failed to do operation foo: Failed to fetch data". - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96421 ----------------------------------------------------------- On Aug. 26, 2015, 1:03 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37427/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 1:03 a.m.) > > > Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Changes: > - Added Token implementation (RFC 7519). > - Added TokenManager implementation. This component keeps a cache of tokens > requested for any future requests. > > > Diffs > ----- > > src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab > src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION > src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37427/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
