> On Aug. 28, 2015, 12:18 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/token_manager.hpp, line 223 > > <https://reviews.apache.org/r/37427/diff/12/?file=1052806#file1052806line223> > > > > Is there a reason you need to include this in the header? Can we just > > put it in cpp? > > Jojy Varghese wrote: > The only reason being that this is a property of the TokenManager. > > Timothy Chen wrote: > I see, does it need to be? Can't we define a static const in the cpp?
We could but then it wont be a class property. Here the constant reflects the property of the class. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96752 ----------------------------------------------------------- On Aug. 28, 2015, 4:27 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37427/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 4:27 a.m.) > > > Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Changes: > - Added Token implementation (RFC 7519). > - Added TokenManager implementation. This component keeps a cache of tokens > requested for any future requests. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION > src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37427/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
