> On Aug. 28, 2015, 12:18 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 203 > > <https://reviews.apache.org/r/37427/diff/12/?file=1052807#file1052807line203> > > > > We usually name the class variable without _, and the parameter with _. > > Jojy Varghese wrote: > Not sure I follow.
Never mind we have new style guides now about this. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review96752 ----------------------------------------------------------- On Aug. 28, 2015, 4:27 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37427/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 4:27 a.m.) > > > Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Changes: > - Added Token implementation (RFC 7519). > - Added TokenManager implementation. This component keeps a cache of tokens > requested for any future requests. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION > src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37427/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
