-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37314/#review96548
-----------------------------------------------------------



include/mesos/maintenance/maintenance.hpp (line 29)
<https://reviews.apache.org/r/37314/#comment152070>

    `{` on new line



include/mesos/type_utils.hpp (line 146)
<https://reviews.apache.org/r/37314/#comment152018>

    Can you add another copy of the comment regarding How MachineInfos are 
expected to be matched here?
    I know this seems like overkill, but the IP <-> Hostname thing bites a lot 
of people. Let's take advantage of as many opportunities as possible to help 
them out if they start browsing the code.



include/mesos/type_utils.hpp (line 149)
<https://reviews.apache.org/r/37314/#comment152069>

    expression continuation should be indented by 2, not 4.



src/master/master.hpp (line 893)
<https://reviews.apache.org/r/37314/#comment152074>

    Here is another place where the wording is a little inconsistent.
    
    We can call it `maintenanceInfos` or change the type name. Let's try and 
follow the variable name matching the type name when possible.


- Joris Van Remoortere


On Aug. 24, 2015, 6:43 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37314/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 6:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3045
>     https://issues.apache.org/jira/browse/MESOS-3045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Note: Tests will be added with the related HTTP endpoints and registrar 
> operations, later in this review chain.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
>   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
> 
> Diff: https://reviews.apache.org/r/37314/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to