----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96643 -----------------------------------------------------------
include/mesos/maintenance/maintenance.hpp (line 29) <https://reviews.apache.org/r/37314/#comment152246> If it's not a protobuf, remove `Info` suffix. The suffix is there only to avoid collisions between proto and non-proto classes. Thanks! include/mesos/maintenance/maintenance.hpp (lines 29 - 38) <https://reviews.apache.org/r/37314/#comment152249> I'm getting slightly confused with multiple `Maintenance*` messages and structs : ). How about we combine all similar structs into one protobuf and will re-use it everywhere? Decomposition and microkernels are great, as soon as there not so many connections between shards. How about a message in `maintenance.proto`: ``` message MaintenanceInfo { required MachineInfo = 1; optional Unavailability unavailability = 2 optional Mode = 3; } ``` which then substitutes `MaintenanceStatus` and this struct here? Moreover, it can also replace `Window`. Recovery code will become simpler as well. include/mesos/maintenance/maintenance.hpp (line 36) <https://reviews.apache.org/r/37314/#comment152247> "Window" in the comment is misleading, as there is a protobuf message, which is for multiple machines. Also, shouldn't `MachineInfo` be here as well? Can be handy, once an element is extracted from the hash. - Alexander Rukletsov On Aug. 26, 2015, 6:49 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37314/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 6:49 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3045 > https://issues.apache.org/jira/browse/MESOS-3045 > > > Repository: mesos > > > Description > ------- > > Note: Tests will be added with the related HTTP endpoints and registrar > operations, later in this review chain. > > > Diffs > ----- > > include/mesos/maintenance/maintenance.hpp PRE-CREATION > include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 > src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > > Diff: https://reviews.apache.org/r/37314/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
