> On Aug. 28, 2015, 8:19 a.m., Joris Van Remoortere wrote: > > include/mesos/type_utils.hpp, line 158 > > <https://reviews.apache.org/r/37314/diff/7/?file=1057072#file1057072line158> > > > > You have this on a new line to call it out for readability right? It > > would fit above otherwise.
Yup, that's right. > On Aug. 28, 2015, 8:19 a.m., Joris Van Remoortere wrote: > > include/mesos/type_utils.hpp, line 593 > > <https://reviews.apache.org/r/37314/diff/7/?file=1057072#file1057072line593> > > > > You don't need the `std::` in `std::size_t`. I know you followed the > > pattern that got committed recently, it got followed up with this change :-) Got it. I didn't see the change until I rebased a few moments ago. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/#review96870 ----------------------------------------------------------- On Aug. 28, 2015, 10:38 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37314/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 10:38 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3045 > https://issues.apache.org/jira/browse/MESOS-3045 > > > Repository: mesos > > > Description > ------- > > Note: Tests will be added with the related HTTP endpoints and registrar > operations, later in this review chain. > > > Diffs > ----- > > include/mesos/type_utils.hpp 1c8f95b894285140a228ab4202851ee391ffdcc6 > src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > > Diff: https://reviews.apache.org/r/37314/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
