----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review96541 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker/backend.cpp (line 96) <https://reviews.apache.org/r/37200/#comment151987> Insert blank line here please. src/slave/containerizer/provisioners/docker/store.hpp (line 26) <https://reviews.apache.org/r/37200/#comment151997> Missing ``` #include <stout/nothing.hpp> ``` src/slave/containerizer/provisioners/docker/store.hpp (line 43) <https://reviews.apache.org/r/37200/#comment151999> Please add a short abstract comment describing the purpose of this interface. src/slave/containerizer/provisioners/docker/store.hpp (line 53) <https://reviews.apache.org/r/37200/#comment151988> s/ to// src/slave/containerizer/provisioners/docker/store.hpp (line 76) <https://reviews.apache.org/r/37200/#comment152002> Consider adding a protected constructor to underline the fact that this is a pure virtual interface. src/slave/containerizer/provisioners/docker/store.hpp (line 78) <https://reviews.apache.org/r/37200/#comment151992> Kill this blank line please. src/slave/containerizer/provisioners/docker/store.hpp (lines 80 - 82) <https://reviews.apache.org/r/37200/#comment151995> See below on doxygen formatting for such attributing comments. src/slave/containerizer/provisioners/docker/store.hpp (line 85) <https://reviews.apache.org/r/37200/#comment151993> Kill this blank line please. src/slave/containerizer/provisioners/docker/store.hpp (lines 108 - 110) <https://reviews.apache.org/r/37200/#comment151994> I am not sure that using doxygen comments for these attributes is the right way to go. I personally find it wasteful and not helping in readability - but will be easy to get convinced otherwise :) - also I did not check the resulting doxygen HTML on the differences. src/slave/containerizer/provisioners/docker/store.hpp (line 171) <https://reviews.apache.org/r/37200/#comment151998> s/hahsmap/hashmap/ src/slave/containerizer/provisioners/docker/store.cpp (line 100) <https://reviews.apache.org/r/37200/#comment152014> Insert blank line here please. src/slave/containerizer/provisioners/docker/store.cpp (line 115) <https://reviews.apache.org/r/37200/#comment152015> Insert blank line here please. - Till Toenshoff On Aug. 25, 2015, 8:59 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37200/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 8:59 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, > and Jiang Yan Xu. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Refactored DockerImage struct to store a list of layer ids instead of linked > list of DockerLayers. > > > Diffs > ----- > > src/slave/containerizer/provisioners/docker.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37200/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
