----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review96561 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker.hpp (line 61) <https://reviews.apache.org/r/37200/#comment152075> Would a factory method be more apporoprate here(create)? What if the string passed in is arbitary? src/slave/containerizer/provisioners/docker.hpp <https://reviews.apache.org/r/37200/#comment152079> Needs "explicit" on the constructor? src/slave/containerizer/provisioners/docker.hpp (line 62) <https://reviews.apache.org/r/37200/#comment152078> Ctor too long to be eligible for inlined in header file. src/slave/containerizer/provisioners/docker.hpp (lines 66 - 68) <https://reviews.apache.org/r/37200/#comment152073> Can avoid else block as Option state is default constructed to None. src/slave/containerizer/provisioners/docker.hpp (line 69) <https://reviews.apache.org/r/37200/#comment152077> No need for this variable. Could be folded into the "if" condition. src/slave/containerizer/provisioners/docker.cpp (line 189) <https://reviews.apache.org/r/37200/#comment152081> Are we always over writing existing provisioned containers? src/slave/containerizer/provisioners/docker.cpp (line 199) <https://reviews.apache.org/r/37200/#comment152082> Use explicit capture. src/slave/containerizer/provisioners/docker.cpp (line 221) <https://reviews.apache.org/r/37200/#comment152083> Use explicit capture. src/slave/containerizer/provisioners/docker.cpp (line 251) <https://reviews.apache.org/r/37200/#comment152085> What happens on failure? - Jojy Varghese On Aug. 25, 2015, 8:59 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37200/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 8:59 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, > and Jiang Yan Xu. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Refactored DockerImage struct to store a list of layer ids instead of linked > list of DockerLayers. > > > Diffs > ----- > > src/slave/containerizer/provisioners/docker.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37200/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
