> On Sept. 7, 2015, 3:49 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker.cpp, line 280 > > <https://reviews.apache.org/r/37200/diff/12/?file=1056942#file1056942line280> > > > > One space indentation too many :)
Also no longer valid :) > On Sept. 7, 2015, 3:49 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 419 > > <https://reviews.apache.org/r/37200/diff/12/?file=1056944#file1056944line419> > > > > Repeat what? ... seems this comment needs adjustment or removal now > > that the previous comment, this one was referring to, got removed. Also no longer valid :) > On Sept. 7, 2015, 3:49 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 432 > > <https://reviews.apache.org/r/37200/diff/12/?file=1056944#file1056944line432> > > > > Error checking?! Moved to this mkdir on create. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review97910 ----------------------------------------------------------- On Aug. 27, 2015, 11:41 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37200/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:41 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > Timothy Chen, and Jiang Yan Xu. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Refactored DockerImage struct to store a list of layer ids instead of linked > list of DockerLayers. > > > Diffs > ----- > > src/slave/containerizer/provisioners/docker.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37200/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
