> On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 126 > > <https://reviews.apache.org/r/37197/diff/10/?file=1052420#file1052420line126> > > > > s/uri/uri schemes are/ ?
Most of the comments pertaining to uris is changed in review 37200 when the DockerImage struct is refactored. > On Aug. 26, 2015, 5:50 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 211 > > <https://reviews.apache.org/r/37197/diff/10/?file=1052420#file1052420line211> > > > > I thought we got rid of `os::basename` and suggest using > > `Path::basename` instead?! > > `::basename` (which os::basename was relying on) is not thread-safe on > > some systems, please avoid it. os::basename is no longer necessary when the DockerImage scheme changes in 37200. - Lily ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review96496 ----------------------------------------------------------- On Aug. 26, 2015, 5:56 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37197/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 5:56 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > and Timothy Chen. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Stored images currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37197/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
