> On Aug. 31, 2015, 8:09 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 131 > > <https://reviews.apache.org/r/37197/diff/12/?file=1056929#file1056929line131> > > > > For local store I don't think this comment is valid. > > Should just comment that only local images with file:// is supported.
The implemenation gets changed dramatically in the commit 37200 (refactoring docker image struct) so are these comments here still relevant? > On Aug. 31, 2015, 8:09 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/store.cpp, line 247 > > <https://reviews.apache.org/r/37197/diff/12/?file=1056929#file1056929line247> > > > > If tar is terminated in the middle, will this operation succeed again? > > We only check the directory exist to signal that we untarred the layer, but > > it might not necessarily really finished. > > I Think we will have to do a mv here as well So untar into a different temp directory and rename it to appear in the staging directory? - Lily ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review97095 ----------------------------------------------------------- On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37197/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:39 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > and Timothy Chen. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Stored images currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37197/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
