> On Aug. 26, 2015, 9:13 p.m., Joris Van Remoortere wrote: > > @Mpark: For the standard hashers, do we want to follow this pattern? > > ``` > > template <> > > struct hash<T> { > > > > typedef size_t result_type; > > > > typedef T argument_type; > > > > result_type operator()(const argument_type &that) const { > > // body > > } > > > > }; > > ``` > > > > Are we replacing all uses of the hash based boost containers? If so, should > > we clean up the remaining instances of `hash_value` implementations? > > Grepping through I still see some.
@Joris: Thanks for the review! @Jan: (1) Let's follow the pattern Joris mentions above since the standard technically requires the `result_type`, and `argument_type` typedefs. (2) I've pointed out the parts where `hash_value` is still left over in the codebase more specifically in the reviews, let's take care of those as well. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review96593 ----------------------------------------------------------- On Aug. 27, 2015, 11:39 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37188/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:39 a.m.) > > > Review request for mesos, Alexander Rojas and Michael Park. > > > Bugs: MESOS-3217 > https://issues.apache.org/jira/browse/MESOS-3217 > > > Repository: mesos > > > Description > ------- > > Added std::hash template specializations. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > df78f8e525c40b87e734e16979d3315f89e12594 > 3rdparty/libprocess/include/process/pid.hpp > 8d3735c7d5b8f74a7a0ebb8cafe7c7ebee68f5f0 > 3rdparty/libprocess/src/pid.cpp f5528aea04a17ce868a0f67b94defdefea18e234 > 3rdparty/libprocess/src/tests/http_tests.cpp > c22f9d35b5dc959ce9816d3358ebff92b853bf52 > > Diff: https://reviews.apache.org/r/37188/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >