----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96796 -----------------------------------------------------------
include/mesos/maintenance/maintenance.proto (lines 37 - 39) <https://reviews.apache.org/r/36571/#comment152447> Let's extend one of the windows to multiple lines to indicate that a single window can have multiple machines. include/mesos/mesos.proto (line 164) <https://reviews.apache.org/r/36571/#comment152446> Let's add `Info` suffix for clarity. src/Makefile.am (lines 156 - 157) <https://reviews.apache.org/r/36571/#comment152450> Don't we need to add `v1/**` protos somewhere as well? - Alexander Rukletsov On Aug. 27, 2015, 11:41 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36571/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:41 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3066 > https://issues.apache.org/jira/browse/MESOS-3066 > > > Repository: mesos > > > Description > ------- > > New protobufs: > > * MachineAddress - Describes a single box that holds one or more agents. > * MachineAddresses - A list of boxes. > * MachineInfo - Holds a box and some extra information about its status. > * MachineInfo::Mode - An enum for the three states of a machine: UP, > DRAINING, DOWN. > * maintenance::Window - A set of machines and a planned downtime period. > * maintenance::Schedule - A set of maintenance windows. > > > Diffs > ----- > > include/mesos/maintenance/maintenance.hpp PRE-CREATION > include/mesos/maintenance/maintenance.proto PRE-CREATION > include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 > include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 > > Diff: https://reviews.apache.org/r/36571/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
