----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96868 -----------------------------------------------------------
Ship it! include/mesos/maintenance/maintenance.proto (line 56) <https://reviews.apache.org/r/36571/#comment152552> s/Period/Interval/ include/mesos/mesos.proto (line 160) <https://reviews.apache.org/r/36571/#comment152549> `a slave` or `an agent` ? include/mesos/mesos.proto (line 162) <https://reviews.apache.org/r/36571/#comment152550> Is `Missing fields default to the empty string for the purpose of matching` still true? Do you want to mention the hostname comparison is not case sensitive? include/mesos/mesos.proto (lines 170 - 175) <https://reviews.apache.org/r/36571/#comment152551> Did you mention you were getting rid of the list version? Are we still going to use it? include/mesos/v1/mesos.proto (line 162) <https://reviews.apache.org/r/36571/#comment152554> don't forget to update this if you change it in the old proto. include/mesos/v1/mesos.proto (lines 170 - 175) <https://reviews.apache.org/r/36571/#comment152555> in case you decide to remove this in the old proto. src/master/registry.proto (lines 55 - 57) <https://reviews.apache.org/r/36571/#comment152556> Why not follow the wrapper message pattern in the `NOTE` above: ``` message Machines { repeated Machine machines = 1; } ``` Can you add a comment as to why not if you leave it as is? - Joris Van Remoortere On Aug. 28, 2015, 12:57 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36571/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 12:57 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3066 > https://issues.apache.org/jira/browse/MESOS-3066 > > > Repository: mesos > > > Description > ------- > > New protobufs: > > * MachineID - Describes a single box that holds one or more agents. > * MachineIDs - A list of boxes. > * MachineInfo - Holds a box and some extra information about its status. > * MachineInfo::Mode - An enum for the three states of a machine: UP, > DRAINING, DOWN. > * maintenance::Window - A set of machines and a planned downtime period. > * maintenance::Schedule - A set of maintenance windows. > > > Diffs > ----- > > include/mesos/maintenance/maintenance.hpp PRE-CREATION > include/mesos/maintenance/maintenance.proto PRE-CREATION > include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 > include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 > > Diff: https://reviews.apache.org/r/36571/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
