> On Aug. 27, 2015, 4:58 p.m., Alexander Rukletsov wrote:
> > include/mesos/maintenance/maintenance.proto, lines 37-39
> > <https://reviews.apache.org/r/36571/diff/18/?file=1056922#file1056922line37>
> >
> >     Let's extend one of the windows to multiple lines to indicate that a 
> > single window can have multiple machines.

I was thinking the `+` would be appear as part of a bar.  So each window in the 
picture should have 3 machines.
I can change it from a bar to a rectangle.


> On Aug. 27, 2015, 4:58 p.m., Alexander Rukletsov wrote:
> > src/Makefile.am, lines 156-157
> > <https://reviews.apache.org/r/36571/diff/18/?file=1056925#file1056925line156>
> >
> >     Don't we need to add `v1/**` protos somewhere as well?

The `v1/mesos.proto` should have already been added.  We don't add a 
`v1/maintenance.proto`


> On Aug. 27, 2015, 4:58 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, line 164
> > <https://reviews.apache.org/r/36571/diff/18/?file=1056923#file1056923line164>
> >
> >     Let's add `Info` suffix for clarity.

I'll rename it to `MachineID`.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96796
-----------------------------------------------------------


On Aug. 27, 2015, 5:57 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36571/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-3066
>     https://issues.apache.org/jira/browse/MESOS-3066
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> New protobufs:
> 
> * MachineAddress - Describes a single box that holds one or more agents.
> * MachineAddresses - A list of boxes.
> * MachineInfo - Holds a box and some extra information about its status.
> * MachineInfo::Mode - An enum for the three states of a machine: UP, 
> DRAINING, DOWN.
> * maintenance::Window - A set of machines and a planned downtime period.
> * maintenance::Schedule - A set of maintenance windows.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp PRE-CREATION 
>   include/mesos/maintenance/maintenance.proto PRE-CREATION 
>   include/mesos/mesos.proto 715b8cf38e1e56c18a3f2ddbb82c920bd9414f05 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 
> 
> Diff: https://reviews.apache.org/r/36571/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to