> On Aug. 28, 2015, 8:12 a.m., Joris Van Remoortere wrote: > > include/mesos/mesos.proto, line 160 > > <https://reviews.apache.org/r/36571/diff/19/?file=1057056#file1057056line160> > > > > `a slave` or `an agent` ?
Since I added Machine* to the v1 API, I just used "slave" in one, and "agent" in the other. > On Aug. 28, 2015, 8:12 a.m., Joris Van Remoortere wrote: > > include/mesos/mesos.proto, line 162 > > <https://reviews.apache.org/r/36571/diff/19/?file=1057056#file1057056line162> > > > > Is `Missing fields default to the empty string for the purpose of > > matching` still true? > > Do you want to mention the hostname comparison is not case sensitive? Not as true anymore. And yes, I should. > On Aug. 28, 2015, 8:12 a.m., Joris Van Remoortere wrote: > > include/mesos/mesos.proto, lines 170-175 > > <https://reviews.apache.org/r/36571/diff/19/?file=1057056#file1057056line170> > > > > Did you mention you were getting rid of the list version? Are we still > > going to use it? I'll put a TODO here. We'll want to remove it as soon as https://reviews.apache.org/r/37826/ is submitted. > On Aug. 28, 2015, 8:12 a.m., Joris Van Remoortere wrote: > > src/master/registry.proto, lines 55-57 > > <https://reviews.apache.org/r/36571/diff/19/?file=1057059#file1057059line55> > > > > Why not follow the wrapper message pattern in the `NOTE` above: > > ``` > > message Machines { > > repeated Machine machines = 1; > > } > > ``` > > > > Can you add a comment as to why not if you leave it as is? I was conflicted if I wanted a list accessor like `.machines().machines()`, which is what the `slaves` accessor looks like. I'll change it to match the pattern though, since it doesn't have too big of an impact. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/#review96868 ----------------------------------------------------------- On Aug. 28, 2015, 10:20 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36571/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 10:20 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-3066 > https://issues.apache.org/jira/browse/MESOS-3066 > > > Repository: mesos > > > Description > ------- > > New protobufs: > > * MachineID - Describes a single box that holds one or more agents. > * MachineIDs - A list of boxes. > * MachineInfo - Holds a box and some extra information about its status. > * MachineInfo::Mode - An enum for the three states of a machine: UP, > DRAINING, DOWN. > * maintenance::Window - A set of machines and a planned downtime period. > * maintenance::Schedule - A set of maintenance windows. > > > Diffs > ----- > > include/mesos/maintenance/maintenance.hpp PRE-CREATION > include/mesos/maintenance/maintenance.proto PRE-CREATION > include/mesos/mesos.proto c40a09b2bb2b9444e9b90e86eefe6fc8f98b613d > include/mesos/v1/mesos.proto ee15b9ae70aeb8cf803ea7e4b06f4443bd7bc9e2 > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6 > > Diff: https://reviews.apache.org/r/36571/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Joseph Wu > >
