> On Aug. 30, 2015, 2:30 a.m., Guangya Liu wrote:
> > src/docker/docker.cpp, line 169
> > <https://reviews.apache.org/r/37703/diff/2/?file=1059364#file1059364line169>
> >
> >     Why update this? This does not seems to be related to this patch and 
> > also the value should be const as the function only read this value.

Because I think it broke the mesos style 
[here](https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#capture-by-reference).
 I revert this change now.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review97006
-----------------------------------------------------------


On Aug. 29, 2015, 1:51 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 1:51 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
>     https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add docker exec command.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
>   src/tests/containerizer/docker_tests.cpp 
> a4a2725c05ae0cb88426c587f7ded0da77154edc 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to