----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review98054 -----------------------------------------------------------
src/docker/docker.cpp (line 1200) <https://reviews.apache.org/r/37703/#comment154265> 4 space indent instead of 8 src/tests/containerizer/docker_tests.cpp (line 241) <https://reviews.apache.org/r/37703/#comment154264> Please follow how other tests are testing preconditions, one example: ASSERT_SOME( cgroups::memory::oom::killer::enabled(hierarchy, TEST_CGROUPS_ROOT)) << "-------------------------------------------------------------\n" << "We cannot run this test because it appears you do not have\n" << "a modern enough version of the Linux kernel. You won't be\n" << "able to use the cgroups isolator, but feel free to disable\n" << "this test.\n" << "-------------------------------------------------------------"; And also move this to the beginning of the test - Timothy Chen On Aug. 30, 2015, 8:16 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37703/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 8:16 a.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3291 > https://issues.apache.org/jira/browse/MESOS-3291 > > > Repository: mesos > > > Description > ------- > > Add docker exec command. > > > Diffs > ----- > > src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b > src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 > src/tests/containerizer/docker_tests.cpp > a4a2725c05ae0cb88426c587f7ded0da77154edc > > Diff: https://reviews.apache.org/r/37703/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
