-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review97329
-----------------------------------------------------------

Ship it!


Ship It!


src/slave/containerizer/provisioners/docker/token_manager.hpp (line 38)
<https://reviews.apache.org/r/37427/#comment153174>

    Let's remove the provisioners namespace to be at the same level with appc 
provisioner



src/slave/containerizer/provisioners/docker/token_manager.hpp (line 207)
<https://reviews.apache.org/r/37427/#comment153175>

    You should move the Process into the cpp file if you don't plan to inherit 
this for mocking.



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 61)
<https://reviews.apache.org/r/37427/#comment153176>

    Why not just take a copied value, so
    just [](string segment)?



src/slave/containerizer/provisioners/docker/token_manager.cpp (line 299)
<https://reviews.apache.org/r/37427/#comment153177>

    Align this next to ( :
    
    return Failure("Failed to parse JSON Web .." + 
                   token.error());



src/tests/provisioners/docker_provisioner_tests.cpp (line 341)
<https://reviews.apache.org/r/37427/#comment153178>

    I can't tell what's invalid about this?


- Timothy Chen


On Aug. 31, 2015, 10:39 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37427/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 10:39 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes:
>   - Added Token implementation (RFC 7519).
>   - Added TokenManager implementation. This component keeps a cache of tokens
>   requested for any future requests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
>   src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION 
>   src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37427/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to