> On Sept. 1, 2015, 9:13 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/token_manager.cpp, line 61 > > <https://reviews.apache.org/r/37427/diff/17/?file=1060731#file1060731line61> > > > > Its effectively the same. const reference as method argument is just a > > good practice, thats all.
Can you elaborate a bit more on what does the const reference buys us here since you end up removing the const-ness later ? Anyways if you still want to keep it why not name it as a continuation variable ? Something similar to this: string segment_(segment); // Remove const. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review97336 ----------------------------------------------------------- On Aug. 31, 2015, 10:39 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37427/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 10:39 p.m.) > > > Review request for mesos, Lily Chen, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Changes: > - Added Token implementation (RFC 7519). > - Added TokenManager implementation. This component keeps a cache of tokens > requested for any future requests. > > > Diffs > ----- > > src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 > src/slave/containerizer/provisioners/docker/token_manager.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/token_manager.cpp PRE-CREATION > src/tests/provisioners/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37427/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
