----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review97660 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker/store.hpp (line 100) <https://reviews.apache.org/r/37197/#comment153674> Does this need to be in the hpp file? src/slave/containerizer/provisioners/docker/store.hpp (line 146) <https://reviews.apache.org/r/37197/#comment153673> I would rethink the lifecycle management of this poiner. src/slave/containerizer/provisioners/docker/store.cpp (line 49) <https://reviews.apache.org/r/37197/#comment153676> Ususally if you want to provide a factory class that hands out implementations, you use Factory class (commonly known as Factory design pattern). src/slave/containerizer/provisioners/docker/store.cpp (line 139) <https://reviews.apache.org/r/37197/#comment153677> magic numbers (7) is not recommended. src/slave/containerizer/provisioners/docker/store.cpp (line 146) <https://reviews.apache.org/r/37197/#comment153678> What is the workflow for creating these directories? src/slave/containerizer/provisioners/docker/store.cpp (line 238) <https://reviews.apache.org/r/37197/#comment153681> const? - Jojy Varghese On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37197/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:39 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, > and Timothy Chen. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Stored images currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 > src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 > > Diff: https://reviews.apache.org/r/37197/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
