> On Sept. 3, 2015, 6:59 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.hpp, line 100
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056928#file1056928line100>
> >
> >     Does this need to be in the hpp file?

It is in the latest review.


> On Sept. 3, 2015, 6:59 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.hpp, line 146
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056928#file1056928line146>
> >
> >     I would rethink the lifecycle management of this poiner.

We should rethink to fix this from the provisioner interface.


> On Sept. 3, 2015, 6:59 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.cpp, line 49
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056929#file1056929line49>
> >
> >     Ususally if you want to provide a factory class that hands out 
> > implementations, you use Factory class (commonly known as Factory design 
> > pattern).

In this case Store is providing this factory as we have multple implemetations 
later on.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review97660
-----------------------------------------------------------


On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37197/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 11:39 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stored images currently kept indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
> 
> Diff: https://reviews.apache.org/r/37197/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Reply via email to