> On Sept. 23, 2015, 8:52 a.m., Timothy Chen wrote: > > src/slave/containerizer/linux_launcher.cpp, line 117 > > <https://reviews.apache.org/r/38635/diff/2/?file=1081893#file1081893line117> > > > > How about we do what libprocess does where we initialize on each > > system:: call, and you don't have to initialize explicitly
The one in libprocess doesn't take arguments. If we didn't initialize in one place then we'd have to carry the flags around everywhere or have global access to the flags. > On Sept. 23, 2015, 8:52 a.m., Timothy Chen wrote: > > src/slave/containerizer/linux_launcher.cpp, line 128 > > <https://reviews.apache.org/r/38635/diff/2/?file=1081893#file1081893line128> > > > > This seems pretty systemd specific, why not move this into the > > systemd.cpp? This is a unit file specific to what we are doing in the linux launcher. If we want to change some behavior in terms of the executors slice we'll want to do it here. All the generic helper functions are in a separate systemd namespace though :-) - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100171 ----------------------------------------------------------- On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38635/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 8:34 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas > Nielsen, Thomas Rampelberg, and Timothy Chen. > > > Bugs: MESOS-3425 > https://issues.apache.org/jira/browse/MESOS-3425 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/systemd.hpp PRE-CREATION > src/linux/systemd.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.hpp > f6112c98ffcc46ebcaf5581e821d5481d2f6b494 > src/slave/containerizer/linux_launcher.cpp > 459af1b98ba577863d88d521f3ba8792959f42b4 > src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 > src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f > > Diff: https://reviews.apache.org/r/38635/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
