> On Sept. 23, 2015, 10:31 p.m., Kapil Arya wrote: > > src/slave/containerizer/linux_launcher.cpp, line 133 > > <https://reviews.apache.org/r/38635/diff/3/?file=1083336#file1083336line133> > > > > Do we want to ABORT, or return an Error here (and below)? Not sure, if > > we have a policy that I missed. > > Joris Van Remoortere wrote: > We've chosen to abort / exit under these paths because we don't want to > silently (or only with a warning) run in a bad state.
+1 on return Error. We won't run into a bad state because MesosContainerizer::create will fail and slave will abort anyway. We usually return Error in those initialization functions. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100306 ----------------------------------------------------------- On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38635/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 8:34 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas > Nielsen, Thomas Rampelberg, and Timothy Chen. > > > Bugs: MESOS-3425 > https://issues.apache.org/jira/browse/MESOS-3425 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/systemd.hpp PRE-CREATION > src/linux/systemd.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.hpp > f6112c98ffcc46ebcaf5581e821d5481d2f6b494 > src/slave/containerizer/linux_launcher.cpp > 459af1b98ba577863d88d521f3ba8792959f42b4 > src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 > src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f > > Diff: https://reviews.apache.org/r/38635/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
