-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38635/#review100317
-----------------------------------------------------------



src/linux/systemd.hpp (line 34)
<https://reviews.apache.org/r/38635/#comment157495>

    That's a weired dependency. Can you pass in systemd_runtime_directory 
directly:
    
    ```
    void initialize(const string& runtimeDirectory);
    ```



src/linux/systemd.cpp (lines 167 - 180)
<https://reviews.apache.org/r/38635/#comment157500>

    Use os::write?



src/slave/containerizer/linux_launcher.hpp (lines 28 - 30)
<https://reviews.apache.org/r/38635/#comment157501>

    We try to avoid non-POD global variables. You can use:
    
    ```
    static const char SYSTEMD_MESOS_EXECUTORS_SLICE[] = "mesos_executors.slice";
    ```



src/slave/containerizer/linux_launcher.cpp (lines 123 - 124)
<https://reviews.apache.org/r/38635/#comment157498>

    The follow is less jagged.
    
    ```
    const Path path(path::join(
        systemd::runtimeDirectory(),
        SYSTEMD_MESOS_EXECUTORS_SLICE));
    ```



src/slave/containerizer/linux_launcher.cpp (lines 151 - 154)
<https://reviews.apache.org/r/38635/#comment157499>

    Style nits:
    
    ```
    Try<bool> exists = cgroups::exists(
        systemd::nameHierarchy(),
        SYSTEMD_MESOS_EXECUTORS_SLICE);
    ```


- Jie Yu


On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38635/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas 
> Nielsen, Thomas Rampelberg, and Timothy Chen.
> 
> 
> Bugs: MESOS-3425
>     https://issues.apache.org/jira/browse/MESOS-3425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/systemd.hpp PRE-CREATION 
>   src/linux/systemd.cpp PRE-CREATION 
>   src/slave/containerizer/linux_launcher.hpp 
> f6112c98ffcc46ebcaf5581e821d5481d2f6b494 
>   src/slave/containerizer/linux_launcher.cpp 
> 459af1b98ba577863d88d521f3ba8792959f42b4 
>   src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
>   src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
> 
> Diff: https://reviews.apache.org/r/38635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to