----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100332 -----------------------------------------------------------
Ship it! src/linux/systemd.hpp (lines 32 - 33) <https://reviews.apache.org/r/38635/#comment157517> How about a systemd::Flags object? src/linux/systemd.hpp (line 60) <https://reviews.apache.org/r/38635/#comment157516> Why not just have this be `systemd::hierarchy`? src/linux/systemd.cpp (line 44) <https://reviews.apache.org/r/38635/#comment157518> How about we make this a Try<Nothing>, then we can return the error below, and do the EXIT() at the call site in LinuxLauncher where we can add to the message '... considering using --flag1 --flag2 to initialize systemd'. src/slave/containerizer/linux_launcher.cpp (line 125) <https://reviews.apache.org/r/38635/#comment157519> ... to over-ride the settings for the slice that we provide when we create the 'Unit' below. src/slave/containerizer/linux_launcher.cpp (line 137) <https://reviews.apache.org/r/38635/#comment157520> Let's just return 'Failure' here (and all the ones below) rather than aborting. src/slave/containerizer/linux_launcher.cpp (line 144) <https://reviews.apache.org/r/38635/#comment157521> s|service|slice/service| maybe? - Benjamin Hindman On Sept. 24, 2015, 12:12 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38635/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 12:12 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas > Nielsen, Thomas Rampelberg, and Timothy Chen. > > > Bugs: MESOS-3425 > https://issues.apache.org/jira/browse/MESOS-3425 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/systemd.hpp PRE-CREATION > src/linux/systemd.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.hpp > f6112c98ffcc46ebcaf5581e821d5481d2f6b494 > src/slave/containerizer/linux_launcher.cpp > 459af1b98ba577863d88d521f3ba8792959f42b4 > src/slave/flags.hpp b8d6bb4df4bbe0bac72d4b218ec38ad23fa56214 > src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 > > Diff: https://reviews.apache.org/r/38635/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
