----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101339 -----------------------------------------------------------
src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 143) <https://reviews.apache.org/r/38580/#comment158699> I think this is going to crash when user passes in a invalid sec value, since you check for error but you do a get in the if statement. You should break it into two checks and do different actions. Also remove the unnecessary parenthesis around timeoutSecs.isError() src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 179) <https://reviews.apache.org/r/38580/#comment158700> Align << on both lines. src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 191) <https://reviews.apache.org/r/38580/#comment158701> Fix all the indentation with LOGs please. src/slave/containerizer/provisioner/docker/remote_puller.cpp (line 218) <https://reviews.apache.org/r/38580/#comment158703> You're missing the discard case here. If timeout happens, you discard the future and I believe it will call the following callback here. Therefore this is also going to crash if it times out. I suggest we really write tests around these as I don't think this will work at all. - Timothy Chen On Oct. 2, 2015, 5:18 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38580/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2015, 5:18 p.m.) > > > Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Integrated remote puller with store. Tests will follow. > > > Diffs > ----- > > src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805 > src/slave/containerizer/provisioner/docker/local_puller.hpp > 4574e8a04663482625d7b54f765741f221ec13e0 > src/slave/containerizer/provisioner/docker/local_puller.cpp > 4a0b7d11f013941084571f2d89d835a4668a3d8b > src/slave/containerizer/provisioner/docker/puller.hpp > 105b4e75439c2ad4c08e2fd364f288f1d39b9b59 > src/slave/containerizer/provisioner/docker/puller.cpp > cb05324689ffa26ce830b513e2d71b55517da3cb > src/slave/containerizer/provisioner/docker/registry_client.hpp > 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185 > src/slave/containerizer/provisioner/docker/registry_client.cpp > c2040b48ea43fdb29766994c244273d3fa9ee3cd > src/slave/containerizer/provisioner/docker/remote_puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.cpp > cbb67686d45513f0395a0cf1bc5c43cb4935adae > src/slave/flags.hpp f76f0f6a0c7a01c7f061a225d7f6ef52be0ee7b5 > src/slave/flags.cpp 029aa1eb00e1aa3e92c2155925022c17fd905862 > src/tests/containerizer/provisioner_docker_tests.cpp > d895eb9d0723e52cff8b21ef2deeaef1911d019c > > Diff: https://reviews.apache.org/r/38580/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
