----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101727 -----------------------------------------------------------
src/common/resources.cpp (line 875) <https://reviews.apache.org/r/39056/#comment159198> This fix is ok for this ticket; but how to handle other part about cpu()? Here's some question from me: 1. if `epsilon` is 0.01 here, does it mean the min cpu is 0.01? 2. is this the only code that need `epsilon`? It seems not @jieyu/@mcypark, show we start a EPIC to include all precision related ticket? so, we can 1. unify the min cpu/men/disk to user 2. unify the operator/code within allocator 3. unify the precision between backend and UI 4. clarify the requirement to cpu/mem, e.g. whether accept empty cpu/mem Any comments? - Klaus Ma On Oct. 6, 2015, 10:07 p.m., Mandeep Chadha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39056/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 10:07 p.m.) > > > Review request for mesos and Neil Conway. > > > Bugs: MESOS-3552 > https://issues.apache.org/jira/browse/MESOS-3552 > > > Repository: mesos > > > Description > ------- > > Check failed due to double comparison : MESOS-3552. > > > Diffs > ----- > > src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 > src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e > src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 > > Diff: https://reviews.apache.org/r/39056/diff/ > > > Testing > ------- > > Added unit test. > make check successful. > > > Thanks, > > Mandeep Chadha > >
