> On Oct. 16, 2015, 6 p.m., Ian Downes wrote:
> > include/mesos/mesos.proto, lines 702-720
> > <https://reviews.apache.org/r/38117/diff/2/?file=1065464#file1065464line702>
> >
> >     Are the statistics signed? If not, suggest using uint64 type.

Yes, I used uint64 initially and then noticed some TCP stat is -1. :)


> On Oct. 16, 2015, 6 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1171-1174
> > <https://reviews.apache.org/r/38117/diff/2/?file=1065466#file1065466line1171>
> >
> >     Do these inside the parsing loop as you parse each line pair for a 
> > statistics type.

The problem is we don't expose all SNMP stats from kernel here, for example we 
don't care about UDPlite.


> On Oct. 16, 2015, 6 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1140-1141
> > <https://reviews.apache.org/r/38117/diff/2/?file=1065466#file1065466line1140>
> >
> >     Clearer to just declare these inside the loop scope (but my suggestions 
> > below obviate them anyway).

If declared inside the loop, its value can't be kept for the next loop, right? 
We need to at least keep keys across one loop.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38117/#review102933
-----------------------------------------------------------


On Sept. 8, 2015, 9:12 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38117/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 9:12 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone.
> 
> 
> Bugs: MESOS-3365
>     https://issues.apache.org/jira/browse/MESOS-3365
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These stats are those we get by `netstat -s`, they are important for diagnose 
> networking issues.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> 34ba2294b0bd7d57aa9de073692a2ea8ec62681d 
>   src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c 
>   src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d 
> 
> Diff: https://reviews.apache.org/r/38117/diff/
> 
> 
> Testing
> -------
> 
> Manual tests
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Reply via email to