----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review103153 -----------------------------------------------------------
Patch looks great! Reviews applied: [38117] All tests passed. - Mesos ReviewBot On Oct. 19, 2015, 6:49 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38117/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 6:49 p.m.) > > > Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone. > > > Bugs: MESOS-3365 > https://issues.apache.org/jira/browse/MESOS-3365 > > > Repository: mesos > > > Description > ------- > > These stats are those we get by `netstat -s`, they are important for diagnose > networking issues. > > > Diffs > ----- > > include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a81aaaa1cf8002e > src/slave/containerizer/isolators/network/port_mapping.hpp > ae53c1b1716a7ad9c6e64f9079c972bae31e4ed2 > src/slave/containerizer/isolators/network/port_mapping.cpp > e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef > src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > > Diff: https://reviews.apache.org/r/38117/diff/ > > > Testing > ------- > > ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics > --pid=XXXX > > > Thanks, > > Cong Wang > >
