----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103148 -----------------------------------------------------------
Ship it! Gave it a go :) docs/configuration.md (line 1441) <https://reviews.apache.org/r/39447/#comment161095> The "(its default value)" is redundant wrt "(default: true)" at the end of the help message. Can we kill this? s/ the Agent/, the Agent/ docs/configuration.md (line 1444) <https://reviews.apache.org/r/39447/#comment161096> Kill `obviously`? docs/configuration.md (line 1445) <https://reviews.apache.org/r/39447/#comment161097> s/exist a/exist, a/ src/slave/flags.cpp (lines 166 - 169) <https://reviews.apache.org/r/39447/#comment161101> Same comments as for the doc. src/slave/paths.cpp (lines 427 - 429) <https://reviews.apache.org/r/39447/#comment161100> Why not use the same `LOG(WARNING)` statement? That way the entire message will appear together instead of being sliced up by some other concurrent message. - Kapil Arya On Oct. 19, 2015, 3:06 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39447/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 3:06 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3692 > https://issues.apache.org/jira/browse/MESOS-3692 > > > Repository: mesos > > > Description > ------- > > MESOS-3692 - better documented --switch_user flag > Added better logging around the point where the error may occur. > > > Diffs > ----- > > docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 > > Diff: https://reviews.apache.org/r/39447/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
