> On Oct. 19, 2015, 7:27 p.m., Kapil Arya wrote: > > src/slave/paths.cpp, lines 427-429 > > <https://reviews.apache.org/r/39447/diff/2/?file=1101169#file1101169line427> > > > > Why not use the same `LOG(WARNING)` statement? That way the entire > > message will appear together instead of being sliced up by some other > > concurrent message.
Because a priori I don't know what `chown.error()` will emit (can be a multiline error, whatever) and so it may look pretty awful. However, having looked at it - I've actually moved it to the end of the sentence, so it should still look good. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103148 ----------------------------------------------------------- On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39447/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 7:06 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3692 > https://issues.apache.org/jira/browse/MESOS-3692 > > > Repository: mesos > > > Description > ------- > > MESOS-3692 - better documented --switch_user flag > Added better logging around the point where the error may occur. > > > Diffs > ----- > > docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 > > Diff: https://reviews.apache.org/r/39447/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
