----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103146 -----------------------------------------------------------
Thanks for doing this! It's definitely clearer (at least to me) as to what this flag is controlling. A few general comments here: (1) We should be using ``` in some of the cases instead of `'` right? It seems to be a bit inconsistent currently. (2) Based on existing documentation, I don't think we should go out of our way to capitalize `Agent`. docs/configuration.md (line 1441) <https://reviews.apache.org/r/39447/#comment161091> `s/(its default value)//` docs/configuration.md (line 1443) <https://reviews.apache.org/r/39447/#comment161098> > rather than the one running the Agent Let's just mention this once in the `false` case. docs/configuration.md (line 1444) <https://reviews.apache.org/r/39447/#comment161092> `s/, obviously,//` docs/configuration.md (line 1445) <https://reviews.apache.org/r/39447/#comment161094> `s/exist/exist,/` docs/configuration.md (line 1446) <https://reviews.apache.org/r/39447/#comment161099> How about we keep it symmetric? i.e. `If set to `true`, ... . If set to `false`, ... .`? - Michael Park On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39447/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 7:06 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3692 > https://issues.apache.org/jira/browse/MESOS-3692 > > > Repository: mesos > > > Description > ------- > > MESOS-3692 - better documented --switch_user flag > Added better logging around the point where the error may occur. > > > Diffs > ----- > > docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 > > Diff: https://reviews.apache.org/r/39447/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
