> On Oct. 19, 2015, 7:35 p.m., Michael Park wrote: > > Thanks for doing this! It's definitely clearer (at least to me) as to what > > this flag is controlling. > > > > A few general comments here: > > (1) We should be using ``` in some of the cases instead of `'` right? It > > seems to be a bit inconsistent currently. > > (2) Based on existing documentation, I don't think we should go out of our > > way to capitalize `Agent`.
agreed - tried to use `` consistently, and replaced ' - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103146 ----------------------------------------------------------- On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39447/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 7:06 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3692 > https://issues.apache.org/jira/browse/MESOS-3692 > > > Repository: mesos > > > Description > ------- > > MESOS-3692 - better documented --switch_user flag > Added better logging around the point where the error may occur. > > > Diffs > ----- > > docs/configuration.md 69fb37fc38e52277605b82cf67067168a37d79a6 > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 > > Diff: https://reviews.apache.org/r/39447/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
