----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review103954 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 982) <https://reviews.apache.org/r/39401/#comment162063> s/unsatisfiedRoleQuotas/unAllocatedRoleQuotas? src/master/allocator/mesos/hierarchical.cpp (line 1035) <https://reviews.apache.org/r/39401/#comment162061> I know that we have design to exclue the reserved resource from quota, but why not include the current role's reserved as available? src/master/allocator/mesos/hierarchical.cpp (line 1058) <https://reviews.apache.org/r/39401/#comment162064> Where does those offerable resource offered to master? src/master/allocator/mesos/hierarchical.cpp (line 1074) <https://reviews.apache.org/r/39401/#comment162062> s/unsatisfiedRoleQuota/unAllocatedQuota? src/master/allocator/mesos/hierarchical.cpp (line 1102) <https://reviews.apache.org/r/39401/#comment162065> Why adding those resource as allocated? The `resource` here is unAllocated resource, why adding it to allocated? - Guangya Liu On 十月 23, 2015, 4:38 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39401/ > ----------------------------------------------------------- > > (Updated 十月 23, 2015, 4:38 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39401/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
