> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 982
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line982>
> >
> >     s/unsatisfiedRoleQuotas/unAllocatedRoleQuotas?

Dynamic reservations may not be allocated, but should still count towards quota.


> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1035
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1035>
> >
> >     I know that we have design to exclue the reserved resource from quota, 
> > but why not include the current role's reserved as available?

If you mean dynamically reserved resources than yes, we can do that. If you 
mean statically reserved than nope, we decided not to conflate them with quota.


> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1058
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1058>
> >
> >     Where does those offerable resource offered to master?

https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L956

Dropping the issue, feel free to reopen if I haven't answered your question.


> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1074
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1074>
> >
> >     s/unsatisfiedRoleQuota/unAllocatedQuota?

See above.


> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1102
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1102>
> >
> >     Why adding those resource as allocated? The `resource` here is 
> > unAllocated resource, why adding it to allocated?

Later on, during the DRF stage we do some resource math, which should be 
correct: 
https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L910


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review103954
-----------------------------------------------------------


On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 4:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to