> On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405 > > <https://reviews.apache.org/r/39417/diff/1/?file=1100528#file1100528line401> > > > > Why not add a 0x prefix if it's not present so you can use numify? > > > > if (!strings::startsWith(tokens[0], "0x")) { > > ... > > }
This should work too, but I don't feel it is better than my code. > On Oct. 27, 2015, 12:20 a.m., Ian Downes wrote: > > src/slave/flags.cpp, lines 506-513 > > <https://reviews.apache.org/r/39417/diff/1/?file=1100530#file1100530line506> > > > > Why is this description different from the docs? This is a simpler one, details are in docs. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review104119 ----------------------------------------------------------- On Oct. 18, 2015, 12:29 a.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39417/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 12:29 a.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Repository: mesos > > > Description > ------- > > When --egress_unique_flow_per_container is enabled, we need to install a flow > classifier (fq_codel) qdisc on egress side. This flag specifies where to > install it in the hierarchy. By default, we install it at root. But, for > example, if you have already installed HTB qdisc at root, you may want this > to be installed in other place than root, specify an HTB class ID as its > parent here. > > > Diffs > ----- > > docs/configuration.md 9443d5fc2de0f46f9e117b08e29b09ff3a4579c6 > src/slave/containerizer/isolators/network/port_mapping.cpp > e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef > src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 > src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 > > Diff: https://reviews.apache.org/r/39417/diff/ > > > Testing > ------- > > Manual tests, with and without a pre-installed HTB qdisc and classes. > > > Thanks, > > Cong Wang > >
