----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107247 -----------------------------------------------------------
Bad patch! Reviews applied: [40497] Failed command: ./support/apply-review.sh -n -r 40497 Error: 2015-11-19 21:53:08 URL:https://reviews.apache.org/r/40497/diff/raw/ [4367/4367] -> "40497.patch" [1] Successfully applied: Add hex number support to numify() numify() in libprocess uses boost lexical_cast() to cast numbers, but it can not cast a hex number. This patch adds hex support to numify(). Review: https://reviews.apache.org/r/40497 Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: stout: 3rdparty/libprocess/3rdparty/stout/Makefile.am 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp libprocess: 3rdparty/libprocess/3rdparty/Makefile.am Failed to commit patch - Mesos ReviewBot On Nov. 19, 2015, 8:15 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39417/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 8:15 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Repository: mesos > > > Description > ------- > > When --egress_unique_flow_per_container is enabled, we need to install a flow > classifier (fq_codel) qdisc on egress side. This flag specifies where to > install it in the hierarchy. By default, we install it at root. But, for > example, if you have already installed HTB qdisc at root, you may want this > to be installed in other place than root, specify an HTB class ID as its > parent here. > > > Diffs > ----- > > docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > cc0152ce44e9fa34210efda8a1c4a6374167eab1 > src/slave/flags.hpp 6ae7c94d2e05d81c8b970e7dcaa82d8aa4de7936 > src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c > > Diff: https://reviews.apache.org/r/39417/diff/ > > > Testing > ------- > > Manual tests, with and without a pre-installed HTB qdisc and classes. > > > Thanks, > > Cong Wang > >
