----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review104383 -----------------------------------------------------------
Patch looks great! Reviews applied: [39415, 39416, 39417] All tests passed. - Mesos ReviewBot On Oct. 29, 2015, 12:12 a.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39417/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 12:12 a.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Repository: mesos > > > Description > ------- > > When --egress_unique_flow_per_container is enabled, we need to install a flow > classifier (fq_codel) qdisc on egress side. This flag specifies where to > install it in the hierarchy. By default, we install it at root. But, for > example, if you have already installed HTB qdisc at root, you may want this > to be installed in other place than root, specify an HTB class ID as its > parent here. > > > Diffs > ----- > > docs/configuration.md ae9f2612b11447eff92ea85d4191e7011d71b2b2 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 1911ba6518190cbff6d72b56aaa477d508dbd391 > src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 > src/slave/flags.cpp 1362dcebef799399739025171696230bded447dd > > Diff: https://reviews.apache.org/r/39417/diff/ > > > Testing > ------- > > Manual tests, with and without a pre-installed HTB qdisc and classes. > > > Thanks, > > Cong Wang > >
