----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/#review105301 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 92) <https://reviews.apache.org/r/39340/#comment163815> When does no streaming makes sense? I wonder if we should just use streaming as the only option? src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 117) <https://reviews.apache.org/r/39340/#comment163814> why _writeBlob? It's not a continuation from writeBlob right? It should be _saveBlob if it's a continuation src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 629) <https://reviews.apache.org/r/39340/#comment163816> Why don't we just copy on each call? Seems unncessary to have a shared_ptr int especially only one save in flight at a time. src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 718) <https://reviews.apache.org/r/39340/#comment163818> Should we log when we failed to close? src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 728) <https://reviews.apache.org/r/39340/#comment163820> onAny doesn't return anything. We try to propgage the error back to the caller so they log themselves, unless you have more information here to log. src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 729) <https://reviews.apache.org/r/39340/#comment163819> We usually say it's discarded in the message too. - Timothy Chen On Nov. 5, 2015, 7:18 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39340/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 7:18 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > RegistryClient: Added streaming response read > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c > > Diff: https://reviews.apache.org/r/39340/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
