----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/#review105445 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 44) <https://reviews.apache.org/r/39340/#comment164048> We don't use this in this patch. src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 478) <https://reviews.apache.org/r/39340/#comment164049> move httpResponse to next line. src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 712) <https://reviews.apache.org/r/39340/#comment164050> I think you need to move the whole function block one space to left (2 space indentation)? src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 722) <https://reviews.apache.org/r/39340/#comment164052> Please let's not return anything in onXXX blocks!!!!!!! src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 728) <https://reviews.apache.org/r/39340/#comment164051> Align this with the top - Timothy Chen On Nov. 6, 2015, 3:50 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39340/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 3:50 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > RegistryClient: Added streaming response read > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c > > Diff: https://reviews.apache.org/r/39340/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
