-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/#review105357
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 637)
<https://reviews.apache.org/r/39340/#comment163918>

    How about:
    size_t newTotalSize = data.length() + totalSize;
    
     return _saveBlob(fd, data.data(), data.length())
            .then([this, fd, reader, newSize](
                )  -> Future<size_t> {
    
              return saveBlob(fd, const_cast<Pipe::Reader&>(reader), 
newTotalSize);
            });
            
    Then you shouldn't need any mutable marks right?


- Timothy Chen


On Nov. 6, 2015, 12:38 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39340/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 12:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RegistryClient: Added streaming response read
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39340/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to