----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review105806 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 337) <https://reviews.apache.org/r/39399/#comment164461> let's pull fixes like this out separately. I'll gladly commit it as a distinct patch. src/master/allocator/mesos/hierarchical.hpp (line 354) <https://reviews.apache.org/r/39399/#comment164467> s/tie quota to/associate quota with/ src/master/allocator/mesos/hierarchical.cpp (lines 46 - 49) <https://reviews.apache.org/r/39399/#comment164468> can we move these up above with the other using declarations? src/master/allocator/mesos/hierarchical.cpp (line 130) <https://reviews.apache.org/r/39399/#comment164469> Can you split out the removal of the namespaces (e.g. `std::` and `mesos::master::`) in to a separate review so that we can keep the quota specific changes concise? - Joris Van Remoortere On Nov. 5, 2015, 6:23 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39399/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 6:23 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39399/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
