> On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 337
> > <https://reviews.apache.org/r/39399/diff/3/?file=1105056#file1105056line337>
> >
> >     let's pull fixes like this out separately. I'll gladly commit it as a 
> > distinct patch.
> 
> Alexander Rukletsov wrote:
>     I would argue that this review is actually that distinct patch. It is not 
> directly related to quota, shall I remove "quota" from the description and 
> move that single comment to the next review for clarity?

Created and submitted for review: 
https://issues.apache.org/jira/browse/MESOS-3884


> On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 130
> > <https://reviews.apache.org/r/39399/diff/3/?file=1105057#file1105057line130>
> >
> >     Can you split out the removal of the namespaces (e.g. `std::` and 
> > `mesos::master::`) in to a separate review so that we can keep the quota 
> > specific changes concise?
> 
> Alexander Rukletsov wrote:
>     As I mentioned above, this review is a basic refactoring, which removes 
> namespaces and wrap role related stuff in a dedicated type.

Created and submitted for review: 
https://issues.apache.org/jira/browse/MESOS-3884


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39399/#review105806
-----------------------------------------------------------


On Nov. 10, 2015, 11:02 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39399/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 11:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cd0d3e0bd234fcf4db9af2e376ea311937204f75 
>   src/master/allocator/mesos/hierarchical.cpp 
> 14fef63714721fcda7cea3c28704766efda6d007 
> 
> Diff: https://reviews.apache.org/r/39399/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to