> On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 337 > > <https://reviews.apache.org/r/39399/diff/3/?file=1105056#file1105056line337> > > > > let's pull fixes like this out separately. I'll gladly commit it as a > > distinct patch.
I would argue that this review is actually that distinct patch. It is not directly related to quota, shall I remove "quota" from the description and move that single comment to the next review for clarity? > On Nov. 10, 2015, 8:56 a.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 130 > > <https://reviews.apache.org/r/39399/diff/3/?file=1105057#file1105057line130> > > > > Can you split out the removal of the namespaces (e.g. `std::` and > > `mesos::master::`) in to a separate review so that we can keep the quota > > specific changes concise? As I mentioned above, this review is a basic refactoring, which removes namespaces and wrap role related stuff in a dedicated type. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39399/#review105806 ----------------------------------------------------------- On Nov. 5, 2015, 6:23 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39399/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 6:23 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39399/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
