----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/#review105954 -----------------------------------------------------------
Looks good overall. docs/authorization.md (line 35) <https://reviews.apache.org/r/39289/#comment164653> Can you also change the "framework" (in `Resource roles that framework can`) to plural? src/master/quota_handler.cpp (line 318) <https://reviews.apache.org/r/39289/#comment164655> Can you add a comment here (or somewhere describing this helper) about how `validateQuotaRequest` will always set the role? Otherwise, it looks like you're checking one optional field, but not this one. - Joseph Wu On Nov. 10, 2015, 4:56 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39289/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 4:56 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till > Toenshoff. > > > Bugs: MESOS-3862 > https://issues.apache.org/jira/browse/MESOS-3862 > > > Repository: mesos > > > Description > ------- > > Added authorization of quota requests. > > > Diffs > ----- > > docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 > include/mesos/authorizer/authorizer.hpp > d667a52f90f970a313580446a5a006cec4b5e25b > include/mesos/authorizer/authorizer.proto > 86bbb45f9d91b4098a262e3e50a793f3bb39497e > include/mesos/quota/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 > src/authorizer/local/authorizer.hpp > 32de102fd588f029882ef2222121ca83a7410c65 > src/authorizer/local/authorizer.cpp > 6d7da87731a438c2180cf91003e09d4aa5a1c773 > src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 > src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 > src/master/quota_handler.cpp PRE-CREATION > src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a > > Diff: https://reviews.apache.org/r/39289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
